Russell King - ARM Linux

Actually, that's probably the whole point of this - to do nothing.
This changes the behaviour of the idle loop from using the WFI to
just spinning instead with no wait-for-interrupt or anything else.
We just keep reading the need_resched flag.

That's much better than the commented out code which opens a mighty
big race condition which will then give bad scheduling behaviour,
allowing the idle task to sleep in WFI until the next interrupt while
the need_resched flag may be set.

Sure, there's better ways to do this, via the disable_hlt() stuff,
and whatever its replacement implementation is now called.  But
ultimately this workaround really is about "doing nothing" when
idle!

Read more »

Still no capabilities in the above - how does the CLCD controller know
which of BGR or RGB output and which format these panels support?

Each entry needs a .caps = CLCD_CAP_xxx | CLCD_CAP_xxx listing the
formats supported there.

Unless panels and the board have a .caps entry, the caps system won't
be used.

Your board has logic to support the RGB444/BGR444 mode?  If not, setting
CLCD_CAP_ALL is incorrect.

Almost-but-not-quite-Acked-by: Russell King <rmk+kernel*******> :)

Remember we talked about the 'gpio' mode as well, so you also need here
+    if ('g' == str[0])
        reboot_mode = REBOOT_GPIO;

Read more »