[PATCH] dma-mapping: Add BUG_ON for uninitialized dma_ops
Tue, 11 Jun 2013 04:04:10 -0700 Post Comments
Hello,
I think that I've copied it from dma_alloc_coherent() in microblaze. You
are right that lack
of this check will also trigger oops in ops==NULL case, but I think that
adding explicit check
in all functions, which use it, is a good idea. It serves as a kind of
documentation and
emphasizes that missing ops is really an issue.
Best regards
--
Marek Szyprowski
Samsung R&D Institute Poland
I think that I've copied it from dma_alloc_coherent() in microblaze. You
are right that lack
of this check will also trigger oops in ops==NULL case, but I think that
adding explicit check
in all functions, which use it, is a good idea. It serves as a kind of
documentation and
emphasizes that missing ops is really an issue.
Best regards
--
Marek Szyprowski
Samsung R&D Institute Poland
